BUG: pandas.cut and negative values #14652 #14663
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests pls |
|
pls add an entry in whatsnew for 0.19.2 |
Current coverage is 85.28% (diff: 100%)@@ master #14663 diff @@
==========================================
Files 140 140
Lines 50693 50693
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43234 43234
Misses 7459 7459
Partials 0 0
|
|
Please let me know if that's ok because I wasn't sure where to add the test case. |
jreback
reviewed
Nov 16, 2016
| @@ -25,3 +25,4 @@ Bug Fixes | |||
|
|
|||
| - compat with ``dateutil==2.6.0`` for testing (:issue:`14621`) | |||
| - allow ``nanoseconds`` in ``Timestamp.replace`` kwargs (:issue:`14621`) | |||
| - fix ``pandas.cut`` with one negative value and one bin (:issue:`14652`) | |||
jreback
reviewed
Nov 16, 2016
|
|
||
| expected = pd.Series([0, 0]) | ||
|
|
||
| s = pd.Series([9., 9.]) |
There was a problem hiding this comment.
pandas\tools\tests\test_tile.py
lots of tests there, just add this one on., no need to create a new class. add a comment with the issue number
|
Thanks @jreback, now it should be fine. |
|
thanks! |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Dec 14, 2016
…s-dev#14652 closes pandas-dev#14652 Author: Luca Scarabello <luca.scarabello@sed.ethz.ch> Author: Luca <luca.scarabello@gmail.com> Closes pandas-dev#14663 from luca-s/issue_14652 and squashes the following commits: 8db26db [Luca Scarabello] Moved new test location to pandas\tools\tests\test_tile.py 90dd07d [Luca Scarabello] Updated whatsnew d6b3da8 [Luca Scarabello] fixed flake8 compliance fdc55b9 [Luca Scarabello] Added test case for pandas-dev#14652 d5790e2 [Luca Scarabello] updated whatsnew v0.19.2 2db0c7a [Luca] BUG: pandas.cut and negative values pandas-dev#14652 (cherry picked from commit 2fc0c68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff